Merged
Conversation
stcheng
approved these changes
Nov 1, 2017
Contributor
stcheng
left a comment
stcheng
left a comment
There was a problem hiding this comment.
could we have some specific test to verify this code change?
Contributor
|
will this command enough? or do we need |
lguohan
approved these changes
Nov 1, 2017
qiluo-msft
pushed a commit
that referenced
this pull request
Nov 2, 2017
This was referenced Nov 7, 2019
lguohan
added a commit
to lguohan/sonic-buildimage
that referenced
this pull request
Nov 9, 2019
swss: * f354798 2019-11-09 | [tests] fix build agains real SAI (sonic-net#1123) (HEAD, origin/master, origin/HEAD) [Stepan Blyshchak] * 56d66a1 2019-11-07 | Sub port interface implementation (sonic-net#969) [Wenda Ni] * c57fc34 2019-11-07 | [bufferorch] Fixed buffer and buffer profile attributes types accoring to changes in SAI 1.5 (sonic-net#1120) [Vitaliy Senchyshyn] * 85ff17d 2019-11-07 | [VRF]: submit vrf feature (sonic-net#943) [Tyler Li] * 5604566 2019-11-06 | [vs_test] fix fdb test failed randomly (sonic-net#1118) [Tyler Li] * 038d994 2019-11-05 | [vnet]: Correct VNET route table size for BITMAP implementation (sonic-net#1115) [Volodymyr Samotiy] * bb4e19c 2019-11-04 | Not wait till kernel net_devices are created for all physical ports to (sonic-net#1109) [Wenda Ni] * bab7b93 2019-11-02 | [portsorch] fix PortsOrch::allPortsReady() returns true when it should not (sonic-net#1103) [Stepan Blyshchak] * 5ab3f6b 2019-10-31 | Updating pytest for sflow (sonic-net#1095) [Sudharsan D.G] * d4ccdc3 2019-10-29 | Quote input strings before constructing a command line (sonic-net#1098) [Qi Luo] * 5516ec4 2019-10-29 | Check RIF/Port exists only for add entries (sonic-net#1110) [Prince Sunny] * 59440f2 2019-10-29 | Allow buffer profile apply after init (sonic-net#1099) [Wenda Ni] sairedis: * d9faa58 2019-10-24 | Copp changes for supporting genetlink in vs (sonic-net#522) [Sudharsan D.G] utiltiies: * e4a5e4c 2019-11-07 | Do not start pfcwd for M0 devices (sonic-net#726) (HEAD, origin/master, origin/HEAD) [Neetha John] * 2c0af8a 2019-11-07 | Add an on/off knob for BGP EOIU pulling on warm restart (sonic-net#655) [heidinet2007] * 2bce9ce 2019-11-07 | Make configlet application script idempotent for updates. (sonic-net#728) [Renuka Manavalan] * 4740617 2019-11-06 | Revert "show BPS, PPS, UTIL rates w/o previous clear (sonic-net#508)" (sonic-net#718) [Mykola F]
lguohan
added a commit
that referenced
this pull request
Nov 10, 2019
swss: * f354798 2019-11-09 | [tests] fix build agains real SAI (#1123) (HEAD, origin/master, origin/HEAD) [Stepan Blyshchak] * 56d66a1 2019-11-07 | Sub port interface implementation (#969) [Wenda Ni] * c57fc34 2019-11-07 | [bufferorch] Fixed buffer and buffer profile attributes types accoring to changes in SAI 1.5 (#1120) [Vitaliy Senchyshyn] * 85ff17d 2019-11-07 | [VRF]: submit vrf feature (#943) [Tyler Li] * 5604566 2019-11-06 | [vs_test] fix fdb test failed randomly (#1118) [Tyler Li] * 038d994 2019-11-05 | [vnet]: Correct VNET route table size for BITMAP implementation (#1115) [Volodymyr Samotiy] * bb4e19c 2019-11-04 | Not wait till kernel net_devices are created for all physical ports to (#1109) [Wenda Ni] * bab7b93 2019-11-02 | [portsorch] fix PortsOrch::allPortsReady() returns true when it should not (#1103) [Stepan Blyshchak] * 5ab3f6b 2019-10-31 | Updating pytest for sflow (#1095) [Sudharsan D.G] * d4ccdc3 2019-10-29 | Quote input strings before constructing a command line (#1098) [Qi Luo] * 5516ec4 2019-10-29 | Check RIF/Port exists only for add entries (#1110) [Prince Sunny] * 59440f2 2019-10-29 | Allow buffer profile apply after init (#1099) [Wenda Ni] sairedis: * d9faa58 2019-10-24 | Copp changes for supporting genetlink in vs (#522) [Sudharsan D.G] utiltiies: * e4a5e4c 2019-11-07 | Do not start pfcwd for M0 devices (#726) (HEAD, origin/master, origin/HEAD) [Neetha John] * 2c0af8a 2019-11-07 | Add an on/off knob for BGP EOIU pulling on warm restart (#655) [heidinet2007] * 2bce9ce 2019-11-07 | Make configlet application script idempotent for updates. (#728) [Renuka Manavalan] * 4740617 2019-11-06 | Revert "show BPS, PPS, UTIL rates w/o previous clear (#508)" (#718) [Mykola F]
zhenggen-xu
pushed a commit
to zhenggen-xu/sonic-buildimage
that referenced
this pull request
Jan 10, 2020
swss: * f354798 2019-11-09 | [tests] fix build agains real SAI (sonic-net#1123) (HEAD, origin/master, origin/HEAD) [Stepan Blyshchak] * 56d66a1 2019-11-07 | Sub port interface implementation (sonic-net#969) [Wenda Ni] * c57fc34 2019-11-07 | [bufferorch] Fixed buffer and buffer profile attributes types accoring to changes in SAI 1.5 (sonic-net#1120) [Vitaliy Senchyshyn] * 85ff17d 2019-11-07 | [VRF]: submit vrf feature (sonic-net#943) [Tyler Li] * 5604566 2019-11-06 | [vs_test] fix fdb test failed randomly (sonic-net#1118) [Tyler Li] * 038d994 2019-11-05 | [vnet]: Correct VNET route table size for BITMAP implementation (sonic-net#1115) [Volodymyr Samotiy] * bb4e19c 2019-11-04 | Not wait till kernel net_devices are created for all physical ports to (sonic-net#1109) [Wenda Ni] * bab7b93 2019-11-02 | [portsorch] fix PortsOrch::allPortsReady() returns true when it should not (sonic-net#1103) [Stepan Blyshchak] * 5ab3f6b 2019-10-31 | Updating pytest for sflow (sonic-net#1095) [Sudharsan D.G] * d4ccdc3 2019-10-29 | Quote input strings before constructing a command line (sonic-net#1098) [Qi Luo] * 5516ec4 2019-10-29 | Check RIF/Port exists only for add entries (sonic-net#1110) [Prince Sunny] * 59440f2 2019-10-29 | Allow buffer profile apply after init (sonic-net#1099) [Wenda Ni] sairedis: * d9faa58 2019-10-24 | Copp changes for supporting genetlink in vs (sonic-net#522) [Sudharsan D.G] utiltiies: * e4a5e4c 2019-11-07 | Do not start pfcwd for M0 devices (sonic-net#726) (HEAD, origin/master, origin/HEAD) [Neetha John] * 2c0af8a 2019-11-07 | Add an on/off knob for BGP EOIU pulling on warm restart (sonic-net#655) [heidinet2007] * 2bce9ce 2019-11-07 | Make configlet application script idempotent for updates. (sonic-net#728) [Renuka Manavalan] * 4740617 2019-11-06 | Revert "show BPS, PPS, UTIL rates w/o previous clear (sonic-net#508)" (sonic-net#718) [Mykola F]
madhanmellanox
pushed a commit
to madhanmellanox/sonic-buildimage
that referenced
this pull request
Mar 23, 2020
* Quote input strings before constructing a command line * Fix an input injection with embedded command * Use dash double quotation instead of bash $'string' style quotation, because system() and popen() will use `sh` internally and `sh` is symlink of `dash` on Debian
dgsudharsan
pushed a commit
to dgsudharsan/sonic-buildimage
that referenced
this pull request
May 12, 2025
…e buffer template for SN5610/SN5600/SN5640 SKUs (sonic-net#1098) <!-- Please make sure you've read and understood our contributing guidelines: https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md failure_prs.log Make sure all your commits include a signature generated with `git commit -s` ** If this is a bug fix, make sure your description includes "fixes #xxxx", or "closes #xxxx" or "resolves #xxxx" Please provide the following information: --> #### Why I did it Split buffer queue configuration in the buffer template for SN5610/SN5600/SN5640 SKUs ##### Work item tracking - Microsoft ADO **(number only)**: #### How I did it #### How to verify it <!-- If PR needs to be backported, then the PR must be tested against the base branch and the earliest backport release branch and provide tested image version on these two branches. For example, if the PR is requested for master, 202211 and 202012, then the requester needs to provide test results on master and 202012. --> #### Which release branch to backport (provide reason below if selected) <!-- - Note we only backport fixes to a release branch, *not* features! - Please also provide a reason for the backporting below. - e.g. - [x] 202006 --> - [ ] 201811 - [ ] 201911 - [ ] 202006 - [ ] 202012 - [ ] 202106 - [ ] 202111 - [ ] 202205 - [ ] 202211 - [ ] 202305 #### Tested branch (Please provide the tested image version) <!-- - Please provide tested image version - e.g. - [x] 20201231.100 --> - [ ] <!-- image version 1 --> - [ ] <!-- image version 2 --> #### Description for the changelog <!-- Write a short (one line) summary that describes the changes in this pull request for inclusion in the changelog: --> <!-- Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU. --> #### Link to config_db schema for YANG module changes <!-- Provide a link to config_db schema for the table for which YANG model is defined Link should point to correct section on https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-yang-models/doc/Configuration.md --> #### A picture of a cute animal (not mandatory but encouraged)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
In ntp-config service, explicitly restart ntp service after generating ntp.conf file